bryancall commented on code in PR #13749:
URL: https://github.com/apache/trafficserver/pull/13749#discussion_r4148124926
##########
tests/gold_tests/autest-site/trafficserver.test.ext:
##########
@@ -394,6 +402,12 @@ def MakeATSProcess(
# For config reload tests, no need to wait the default 3 seconds to detect
the need for a reload.
p.Disk.records_config.update({'proxy.config.config_update_interval_ms':
20})
+ # The default rolling_enabled of 1 rolls every log on a timer, daily at
00:00 UTC. A test
+ # that is running across midnight then checks the fresh, empty file and
fails. 0 turns
+ # rolling off; tests that exercise rolling set rolling_enabled themselves,
overriding this.
Review Comment:
Agreed, and thanks. I will add it as a separate PR rather than here: a
Catch2 test that calls `LogObject::roll_files()` with synthetic times
(23:59:59, then 00:00:01) and checks that the log is renamed to `*.old` and
that the next record lands in the new file. `roll_files()` takes the current
time as an argument, so the test needs no wall-clock wait, where an AuTest
would sit through a real rolling interval.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
