ishaaaan17 commented on code in PR #13934:
URL: https://github.com/apache/trafficserver/pull/13934#discussion_r4415330477
##########
plugins/header_rewrite/condition.cc:
##########
@@ -165,5 +165,7 @@ Condition::initialize(Parser &p)
}
_cond_op = parse_matcher_op(p.get_arg());
- p.validate_mods();
+ if (!p.validate_mods()) {
Review Comment:
good catch! removed the stale `ToDo: ATS v11 fix` comment from
`Parser::validate_mods()` in 68d045055.
##########
plugins/header_rewrite/condition.cc:
##########
@@ -165,5 +165,7 @@ Condition::initialize(Parser &p)
}
_cond_op = parse_matcher_op(p.get_arg());
- p.validate_mods();
+ if (!p.validate_mods()) {
Review Comment:
added `[[nodiscard]]` to `Parser::validate_mods()` in `parser.h` in
68d045055. thank you for the suggestion, this ensures any future caller cannot
accidentally ignore validation errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
