ishaaaan17 commented on code in PR #13934:
URL: https://github.com/apache/trafficserver/pull/13934#discussion_r4421318727
##########
plugins/header_rewrite/header_rewrite.cc:
##########
@@ -630,10 +629,12 @@ TSPluginInit(int argc, const char *argv[])
got_config = true;
} else {
TSError("[%s] failed to parse configuration file %s", PLUGIN_NAME,
argv[i]);
+ parse_success = false;
+ break;
}
}
- if (got_config) {
+ if (got_config && parse_success) {
Review Comment:
[P1] make a failed global configuration abort startup
addressed in 6aae1610f. in `TSPluginInit()`, if any global configuration
file fails `parse_config()`, or if no configuration files are passed, `conf` is
cleaned up and `TSFatal` is invoked immediately. this ensures traffic server
aborts startup rather than running with global header rewrite rules disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
