JosiahWI commented on code in PR #13934:
URL: https://github.com/apache/trafficserver/pull/13934#discussion_r4414034500
##########
plugins/regex_remap/regex_remap.cc:
##########
@@ -655,47 +656,45 @@ compile_rule_set(std::string const &filename, std::string
const &source)
}
pos1 = line.find_first_not_of(" \t\n");
- if (pos1 != std::string::npos) {
- if (line[pos1] == '#') {
- continue;
- }
+ if (pos1 == std::string::npos || line[pos1] == '#') {
+ continue;
+ }
Review Comment:
This is a logic change that wasn't mentioned in the PR description: empty
lines are now skipped without any message, where they would previously have
failed with a "no regex found" message. Was this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
