I've just forced push a rebased version of the branch with some minor extra commits.

Please, take a look and let me know what you think.

Thanks,

Rodrigo.

Em 30-08-2011 16:39, Rodrigo Rosenfeld Rosas escreveu:
Hi, I've just added this test to my devise-openid branch and the tests have passed :D

Great! So, now, I would like you to review my devise-openid branch for merging it with master.

While you review, I'll try to rebase it to current master. Feel free if you would like some commits to be merged or cleaned up. I'm getting really good with "git rebase -i" :D

Best,

Rodrigo.

Em 30-08-2011 10:02, Marius Mårnes Mathiesen escreveu:
On Tue, Aug 30, 2011 at 1:04 PM, Rodrigo Rosenfeld Rosas <[email protected] <mailto:[email protected]>> wrote:

    Would you prefer to have an "slow-integration" extra directory so
    that a "rake test" would skip those tests and we wouldn't run it
    that often? That way I could write a "test-slow" rake task for
    running those tests separately.


Another option could be to run the slow tests if a certain environment variable is set, ie

  LOTS_OF_TIME_TO_SPARE=true rake test:integration

Your call.

- M
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]


--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]

Reply via email to