Em 31-08-2011 11:15, Marius Mårnes Mathiesen escreveu:
On Tue, Aug 30, 2011 at 9:56 PM, Rodrigo Rosenfeld Rosas
<[email protected] <mailto:[email protected]>> wrote:
I've just forced push a rebased version of the branch with some
minor extra commits.
Please, take a look and let me know what you think.
Looks good! A few comments:
- Is it necessary to kill with the KILL signal when stopping the Rots
server (slow_tests.rake line 15)?
That wasn't my first trial. I tried "HUP" first, but I was getting an
exception so I gave up and used KILL instead. If you could make it work
with HUP, great.
- Since we already have a rake/ruby process running, could we use a
Rake task for running the tests (test:slow:run)?
I think it should be possible to do something like:
Rake::TestTask.new("slow_tests") do |test|
test.pattern = "test/slow/*.rb"
end
task :run => [:start, :slow_tests] do
stop
end
?
Sorry, I'm not that good in Rake. Could you explains in details what
you're willing to achieve? I still didn't understand what you are asking
for (or suggesting)...
These are personal opinions only, feel free to ignore them :-)
I love personal opinions! :) I never ignore them :)
Also, I'd like to take the chance to better understand what you would
like me to work on from now on. Is there any other gem not supported by
Rails 3.1?
I want to make sure we don't have any other dependency before start
porting Gitorious to Rails 3.1...
Best,
Rodrigo.
P.S.: I'm not saying I'm done with the Devise integration. Feel free to
ask me to do any further adjustments before it gets integrated. I'm just
saying that I would like to start working in another story while you
review the devise-openid branch.
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
