On 06/09/09 16:42, Pieter de Bie wrote: > I've worked with this a bit, but I don't think it's ready yet. For > example, when rebasing, if the repository refreshes, you can get an > error when both processes try to access the index, as one of them will > already have the lock file. In that case the rebase fails midway, and > there isn't a good way to resume it. That's not acceptable. The other > thing is that the commit view refreshes too often. For example, when > staging a file the whole commit view will refresh, which can take a > long time on large repositories. Hm, I've never encountered an error and I rebased quite a few branches with this new feature.
> I don't think this feature is ready yet. I'm not sure how to fix it, > but we could do something by making sure the refresh doesn't use any > index operations. I think at least we should disable the commit > refresh part. Because of the intrusiveness of the autorefresh stuff, I > think we should delay it for the next version. We can put it in master > once 0.7 hits, and then see if we can fix it. If we aren't able to do > that for the 0.8 timeframe, we can disable it again. Another possibility would be to make the watcher a development-only option. The problem is that if stuff isn't on your branches it is much less likely to be worked on (and one can never be sure if one's changes don't get thrown away). If I take it out I need to know what else goes in, since I likely will have to redo a few of the changes which depended on other commits which had to do with the FSEvents. Right now it looks like I'd exclude the 3 commits from Dave + 1 commit from me (prefs for watcher) and would have to rewrite the last 2 commits on top of that (the "Development tab" thing and the small fix for the "Show open dialog" thing. So, to recapitulate, the patches with - shouldn't go in but the patches with + will (my dg/fsevents) while I have to rewrite the +~: +~ Preferences: Remove description for "Open" pref (Johannes Gilger) +~ Preferences: Add "Development" tab and use it (Johannes Gilger) - PBGitRepoWatcher: Add preference and use it (Johannes Gilger) - PBGitCommit/HistoryController: Use PBGitRepoWatcher (Dave Grijalva) - PBGitRepository: Init PBGitRepositoryWatcher (Dave Grijalva) - Add PBGitRepositoryWatcher with FSEvents (Dave Grijalva) + Add preferences for opening things at launch. (Stonewall Ballard) + PBGitTree: Don't try to print binary-file contents (Johannes Gilger) + Add short SHA to history view (Gerd Knops) If so I can make that happen this afternoon. > Thanks for working on this! Perhaps you can remove the autorefresh > stuff for now? Then perhaps we can release 0.7 today. Yeah, I then also have to rewrite a few small parts of the homepage/release-notes obviously. Greetings, Jojo -- Johannes Gilger <[email protected]> http://heipei.net GPG-Key: 0x42F6DE81 GPG-Fingerprint: BB49 F967 775E BB52 3A81 882C 58EE B178 42F6 DE81
