On Mon, Sep 7, 2009 at 2:18 PM, Johannes Gilger<[email protected]> wrote: > > On 07/09/09 14:11, Pieter de Bie wrote: >> OK, I thought I might as well just do what I described myself. The >> result can be found in my jg/showBinary branch (see 8681420). If you >> agree with the changes, I'll push out 0.7. > > Hmpf, I just finished and sent mine ;) > > One thing about your patch: Lines 139 ad 148 should be the same imho: > return [NSString stringWithFormat:@"%@ appears to be a binary file", [self > fullPath]]; > vs. > return [NSString stringWithFormat:@"%@ appears to be a binary file of %d > bytes", [self fullPath], fileSize]; > > I prefer the latter, but it should be consistent.
I guess you're right. I've changed my version to always show the filesize. It also caches the size, but I'm not sure if that's worth the memory overhead. I guess we can keep it this way, and change it if it runs out of hand. It's 8 bytes / entry, so probably no more than 100K for most repositories.
