On 07/09/09 14:11, Pieter de Bie wrote: > OK, I thought I might as well just do what I described myself. The > result can be found in my jg/showBinary branch (see 8681420). If you > agree with the changes, I'll push out 0.7.
Hmpf, I just finished and sent mine ;) One thing about your patch: Lines 139 ad 148 should be the same imho: return [NSString stringWithFormat:@"%@ appears to be a binary file", [self fullPath]]; vs. return [NSString stringWithFormat:@"%@ appears to be a binary file of %d bytes", [self fullPath], fileSize]; I prefer the latter, but it should be consistent. Greetings, Jojo P.S.: I've already updated our Survs-survey to reflect the fact that Snow Leopard has already been released :P -- Johannes Gilger <[email protected]> http://heipei.net GPG-Key: 0x42F6DE81 GPG-Fingerprint: BB49 F967 775E BB52 3A81 882C 58EE B178 42F6 DE81
