I'm still not sure where to put the sidebar
I think the side is traditional. The left side if you please.
-dave
On Sep 26, 2009, at 9:06 AM, Pieter de Bie <[email protected]>
wrote:
Hey,
That doesn't seem very clear. I've never seen a program use two
different highlights before. It also doesn't solve the problem that
you want to select something that means 'follow the curretn branch,
even if it changes', which won't be possible unless you explicitly
add
something in the tree for that.
I really just meant use the iTunes arrow or something, not a separate
selection. The right click context menu item you suggest would be
perfect. As far as "follow the currently checked out branch,
whatever
it is", I presume you mean follow the history view for that branch.
You could have the "checked out branch" meta branch (along with the
other "meta branches", like All...), and in addition have the iTunes
arrow to indicate which branch (if any) is checked out. This would
offer the bonus of also giving semantic meaning to a headless current
branch (aka unnamed).
Yes, using it as a meta branch seems smart. We should probably put
those on top. We just need another name for 'meta branches' :)
It's already possible to switch branches by right-clicking on a
branch
label and selecting 'checkout branch', which I'll also add to the
sidebar.
Great. So it's just a matter of how to indicate the checked out
branch in the sidebar then.
We might just not do that, and display it somewhere else. It's
currently in the window title, but I think we should put it somewhere
else, that is visible both in the commit view and the history view. We
could do something like "HEAD (master)" as title of the sidebar item
too.
I'm not sure why we should support committing on a different branch?
I've never heard anyone complain about that, and it completely
contradicts how the rest of git works. That just doesn't seem like a
good idea, and IMHO we should just keep to the 'commit on the
current
branch' way that we already have.
I'm confused. I thought we already *did* support it, by right click
on branch labels? For me "committing on a different branch" ==
"selecting a new checkout branch for commits". With the sidebar,
this
can be made much more obvious, even in commit view. Sorry if I was
confusing on this point.
I'm confused too :) I thought you wanted to allow to commit on a
branch other than the current branch. But now I think you mean you
want to support 'check out branch' from the sidebar, which is
something I do want to implement. I guess we should just drop this? :)
I'm still not sure where to put the sidebar. Showing it only in the
history view is the easiest thing to do. However, i've never seen an
application actually remove a sidebar when switching views, so that
doesn't seem too clever to do. Having a 'commit' option still sounds
nice, but I have no idea how to call it in the sidebar. We also still
need good icons for in the sidebar.
I think I'll start merging in the sidebar stuff into 'master' soon,
and just see how that progresses.
