On Mar 17, 2010, at 1:33 PM, Pieter de Bie wrote:
> I think there are some cool features in there, but the UI needs to be
> cleaned up before we can really make it into GitX. I think 5 toolbars
> in a single window is a bit overkill; 5 should be enough.
I suspect you meant something < 5 :)
I think the scope bar (the blue one) should stay as is (though the color
doesn't). All the others I'd be willing to change if someone has a better idea
for how to organize them.
Here are my reasons for putting things where I did:
Add remote/tag, merge, cherry-pick, rebase: these all operate on the selected
commit. I originally had these at the bottom (where gitx already had a toolbar)
but they felt too far removed from items in the commit list. So I put them at
the top. This is a subjective opinion on my part.
Detail/tree view: After moving the others to the top I tried putting this up
there too. But again it felt too far removed from what it operated on.
QuickLook: I'm doing this one separately because I think this should be removed
and somehow (I haven't worked out how yet) be linked to the content view of
items in the tree view. I was going to wait on dealing with this until I added
10.6's QuickLook API to GitX.
I put the remote operations at the bottom under the source view because they
relate to the selection in the source view and not which commit is selected.
With being able to select all branches and local/remote branches in the commit
list it seemed to me that there could be confusion regarding which branch the
remote operations work on. So I was trying to keep them away from the other
buttons that operate on the selected commit.
> I think the best way to integrate this is to split it in semantically
> separate patches and post those to the list. That way we can decide
> which features are appropriate and which need more work.
OK, I'll probably work on that this weekend when I have more time. However,
given recent discussions, I'll just list three here that are related.
Clean up the commit header
<http://github.com/brotherbard/gitx/commit/b557d6b5c6e675216d340d20833f39d0096b7ccc>
- make the "Gist it" button a Mac OS X style button
- remove the default name from each field
- move the author's gravatar and include the committer's
- move the gravatar to the left of the author's name
- add a gravatar for the committer
- move the author and commiter info to it's own table to allow for
putting the gravatar image in a center column
- setGravatar() now uses the email address passed in
Clean up the commit message
<http://github.com/brotherbard/gitx/commit/9a536fc92a83c2fba408ad6d98b281f449882bad>
- allow the commit message text to wrap
- use Menlo on systems that have it
Clean up the commit file list
<http://github.com/brotherbard/gitx/commit/9689c430ef0d337c514095ca533a953365cc6b67>
- remove the underline from file names (makes them easier to read)
- add icons to replace the file modification buttons (icons by Nathan
Kinsinger)
And here is a screenshot showing all the above in action ;)
http://brotherbard.com/gitx/gitx_screenshot_3.png
--Nathan
http://brotherbard.com/
