Hi, On Mar 18, 2:14 am, Nathan Kinsinger <[email protected]> wrote: > On Mar 17, 2010, at 1:33 PM, Pieter de Bie wrote: > > OK, I'll probably work on that this weekend when I have more time. However, > given recent discussions, I'll just list three here that are related. > > Clean up the commit header > <http://github.com/brotherbard/gitx/commit/b557d6b5c6e675216d340d20833...> > - make the "Gist it" button a Mac OS X style button > - remove the default name from each field > - move the author's gravatar and include the committer's > - move the gravatar to the left of the author's name > - add a gravatar for the committer > - move the author and commiter info to it's own table to allow for > putting the gravatar image in a center column > - setGravatar() now uses the email address passed in
I find that rather distracting with the gravatar to the left. Putting the picture too close to the surrounding text makes the surrounding text much harder to read. That is, you’ll find it more difficult to read the actual commit message. A picture is nice as a bonus but as such it works equally well when placed to the right side of the window. (Not to imagine the amounts of people with avatars you don’t care about looking at at all.) > Clean up the commit file list > <http://github.com/brotherbard/gitx/commit/9689c430ef0d337c514095ca533...> > - remove the underline from file names (makes them easier to read) > - add icons to replace the file modification buttons (icons by Nathan > Kinsinger) I must say, I liked the words better than the icons. The ‘edited’ icon feels more like a ‘press to open file in editor’ icon to me. In the end, I think it’s more of a personal preference. But I’d support the old style wordy buttons there. /rike
