On Thu, Mar 18, 2010 at 2:14 AM, Nathan Kinsinger <[email protected]> wrote: > On Mar 17, 2010, at 1:33 PM, Pieter de Bie wrote: > >> I think there are some cool features in there, but the UI needs to be >> cleaned up before we can really make it into GitX. I think 5 toolbars >> in a single window is a bit overkill; 5 should be enough. > > I suspect you meant something < 5 :) eh, 2, right :)
> I think the scope bar (the blue one) should stay as is (though the color > doesn't). All the others I'd be willing to change if someone has a better > idea for how to organize them. I don't get the scrollbar. It's something of a mix of specifying rev parameters and the branch menu on the left. Now you suddenly have two different ways to select a branch -- choose one in the sidebar, or choose something else in the scope bar. Why? How will you ever make this clear to users? > Here are my reasons for putting things where I did: > > Add remote/tag, merge, cherry-pick, rebase: these all operate on the selected > commit. I originally had these at the bottom (where gitx already had a > toolbar) but they felt too far removed from items in the commit list. So I > put them at the top. This is a subjective opinion on my part. > > Detail/tree view: After moving the others to the top I tried putting this up > there too. But again it felt too far removed from what it operated on. > > QuickLook: I'm doing this one separately because I think this should be > removed and somehow (I haven't worked out how yet) be linked to the content > view of items in the tree view. I was going to wait on dealing with this > until I added 10.6's QuickLook API to GitX. > > I put the remote operations at the bottom under the source view because they > relate to the selection in the source view and not which commit is selected. > With being able to select all branches and local/remote branches in the > commit list it seemed to me that there could be confusion regarding which > branch the remote operations work on. So I was trying to keep them away from > the other buttons that operate on the selected commit. I don't think introducing another toolbar is helping to reduce confusion. Can't you just put these on the top? I also think we might want to get away from the black-and-white button things. The difference between the buttons is just too small, and I have no idea what the three different disabled buttons on the top do, or what the difference is between the down arrow and the down-arrow with a stripe below it.
