On Thu, Oct 12, 2006 at 06:50:24PM +0200, Udo Giacomozzi wrote: > There is a #if 0 in gui.cpp that, when activated, shows the changed > region with a red frame (the Flash player has the same option). > > Of course, the most critical part is detection of changes. I > introduced a method called set_invalidated() which gets called > whenever a change is obvious (like adding/removing a character). I > tested this really carefully and hope I did not miss anything. Anyway, > it's really important to always call set_invalidated() whenever code > is added that changed the character instance in a visible way. > > Even if no renderer really uses this information it has effects when > skipping unchanged frames. If necessary, this feature can be switched > off easily in gui.cpp (maybe using a runtime option?).
I've prepared support for the runtime option, my question now is: should I really see any red rectangle with that enabled ? Because I'm not (gtk/ogl). I suppose the rectangle is just too big (and seen your 'sligtly enlarge it due to antialiazing, so it might fall outside of visible area). If I'm right the set_invalidated() call might be a bit too generic, while we might have functions to report exact rectangle being updated (the parent would union oall of invalidated rects in childs). --strk; _______________________________________________ Gnash-commit mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnash-commit
