Hello Jeremiah, > Side question: how do I handle the copyright notice in the top of the files. > David holds copyright over Gnoga. Since this is an extension, do I put my > name in the copyright or his or both?
Yes, since this is a contribution of new source code files from yours included in Gnoga. > That said, I still prefer #2 over #1. I am mostly presenting #1 because it > looks and acts > more like a Gnoga type and I know some people might prefer that. The point is what inherited API user may need and what inherited API you need to implemented new ones. For instance you may need properties API or Execute_Script and user may need dynamic behavior as you stated and so on. Not so easy answer ;-) Though, if #2 better fits into Gnoga then go on this one. My proposal: let's try #2 and let open option #1. Or at your convenience, submit both and let's try both as you proposed. > procedure Create > (Dialog : in out Dialog_Type; > Parent : in out Gnoga.Gui.View.View_Base_Type'Class; > ID : in String := ""); > -- Create a modal dialog using a view as the parent Is it desired to have a modal dialog as child of one view of the window since the window can hold several views. In my understanding, modal dialog is expected blocking for the whole window, isn't it? > -- Shows or hidees a dialog Little typo. > procedure Remove (Dialog : in out Dialog_Type); > -- Removes an element from the DOM, if the ID_Type is DOM_ID, the ID Removes the dialog? By the way, I'm wondering about an English language issue in many source files (not only yours): Some comments are: -- Set the value instead of -- Sets the value What is "good" English writing? HTH, Pascal. http://blady.pagesperso-orange.fr > Le 3 juin 2017 à 02:59, Jeremiah Breeden <jeremiah.bree...@gmail.com> a écrit > : > > Thinking more on it, I probably under represented the cons for #2. > They are all related but just to be complete: > 1. Cannot be used in a lot Gnoga API calls due to not extending any Gnoga > types > 2. Doesn't follow the standard Gnoga creation patterns (the Con I mentioned > ealier) > 3. Unable to set it as Dynamic and have another Gnoga component manage > deleting > pointers to it. So you have to manually manage memory with it (or use a > smart access > container type). > > There may be others that I am not considering. > > That said, I still prefer #2 over #1. I am mostly presenting #1 because it > looks and acts > more like a Gnoga type and I know some people might prefer that. > > On Fri, Jun 2, 2017 at 11:51 AM, Jeffrey R. Carter <jrcar...@acm.org> wrote: > On 06/02/2017 02:44 AM, Jeremiah Breeden wrote: > > So an update. I have two different implementations. They each have pros > > and > > cons and wanted to get feedback on which one would be better to submit. I > > can > > submit both if desired > > I prefer Version 2. Version 1 has too many cons; Version 2 only has 1. > > -- > Jeff Carter > "When and now is this guitar piece from Stottlemeyer? > Yes, it's with Mr. Dog in Gertrude's pinball forest." > The World's Funniest Joke > 133 > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Gnoga-list mailing list > Gnoga-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/gnoga-list > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > Gnoga-list mailing list > Gnoga-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/gnoga-list ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Gnoga-list mailing list Gnoga-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gnoga-list
