Hello Jeremiah, > Le 25 juin 2017 à 16:45, Jeremiah Breeden <jeremiah.bree...@gmail.com> a > écrit : > > Sorry for the lateness of this. My kids have been keeping me busy as of > late. Attached are both versions. I tested compilation by adding them to my > local Gnoga library and using "make gnoga". I tested functionality in > various of my smaller projects (I'll attach a test program I used, but it > isn't gnoga style compliant). That said, I don't know how bullet proof they > are yet. If I had more time, I would have generated a lot of tests. To run > my test program simply call it in your On_Connect handler ina multiconnect > gnoga program like this: > > procedure On_Connect > (Main_Window : in out Gnoga.Gui.Window.Window_Type'Class; > Connection : access > Gnoga.Application.Multi_Connect.Connection_Holder_Type) > is > begin > Test_Dialog.On_Connect(Main_Window,Connection); > end On_Connect; > > > Tested in Windows 10, GNAT GPL 2016, Firefox (current version)
Thanks again for your contribution, however I prefer add a standalone test program than a package as it is easier to build and run. Here is the one I've made from your test package:
test_modal_dialog.adb
Description: Binary data
Is it correct for you ? > > > On Sat, Jun 3, 2017 at 7:08 AM, Pascal <blady-...@users.sf.net> wrote: > Hello Jeremiah, > > > Side question: how do I handle the copyright notice in the top of the > > files. David holds copyright over Gnoga. Since this is an extension, do I > > put my name in the copyright or his or both? > > Yes, since this is a contribution of new source code files from yours > included in Gnoga. > You answered with a yes to a multiple option question, so I may have > misinterpreted, but I think your intent was the "yes" for me putting my name > with the copyright notice. I did that. If we need to put David's name in, > feel free to update that. I'm not very good with this type of stuff. I answer a bit too fast. It's ok for me. > > > > procedure Create > > (Dialog : in out Dialog_Type; > > Parent : in out Gnoga.Gui.View.View_Base_Type'Class; > > ID : in String := ""); > > -- Create a modal dialog using a view as the parent > > Is it desired to have a modal dialog as child of one view of the window since > the window can hold several views. > In my understanding, modal dialog is expected blocking for the whole window, > isn't it? > > In general, yes, it usually only blocks the window. I had one test case ( a > mini ide type mockup) where I wanted the dialog to block a cell in a grid > view only, so that is what that is for. Again, not extensively tested, but > it works in my small test cases. If it is too much, we can remove this > Create procedure. The test program I attached has an example. I got it with your test package. > > > > -- Shows or hidees a dialog > > Little typo. > > Thanks! You're welcome. > > > > procedure Remove (Dialog : in out Dialog_Type); > > -- Removes an element from the DOM, if the ID_Type is DOM_ID, the ID > > Removes the dialog? > > Yes, this maybe overkill. It cannot be dynamically managed in version 2 but > you can still remove it from the DOM (if I did it correctly) in cases where > you want to manually manage stuff. Kind of a compromise. any of this stuff > is up for debate/removal. In fact, I was pointing the comment, Shouldn't it be "-- Removes dialog from the DOM..."? > > > <gnoga-gui-modal_dialog.adb><gnoga-gui-modal_dialog.ads><gnoga-gui-view-modal_dialog.adb><gnoga-gui-view-modal_dialog.ads><test_dialog.adb><test_dialog.ads>------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > Gnoga-list mailing list > Gnoga-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/gnoga-list
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Gnoga-list mailing list Gnoga-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gnoga-list
