On Wed, Jun 28, 2017 at 2:26 PM, Pascal via Gnoga-list <
gnoga-list@lists.sourceforge.net> wrote:
> Hello Jeremiah,
>
> > Le 25 juin 2017 à 16:45, Jeremiah Breeden <jeremiah.bree...@gmail.com>
> a écrit :
> >
> > Sorry for the lateness of this. My kids have been keeping me busy as of
> late. Attached are both versions. I tested compilation by adding them to
> my local Gnoga library and using "make gnoga". I tested functionality in
> various of my smaller projects (I'll attach a test program I used, but it
> isn't gnoga style compliant). That said, I don't know how bullet proof
> they are yet. If I had more time, I would have generated a lot of tests.
> To run my test program simply call it in your On_Connect handler ina
> multiconnect gnoga program like this:
> >
> > procedure On_Connect
> > (Main_Window : in out Gnoga.Gui.Window.Window_Type'Class;
> > Connection : access
> > Gnoga.Application.Multi_Connect.Connection_Holder_Type)
> > is
> > begin
> > Test_Dialog.On_Connect(Main_Window,Connection);
> > end On_Connect;
> >
> >
> > Tested in Windows 10, GNAT GPL 2016, Firefox (current version)
>
> Thanks again for your contribution, however I prefer add a standalone test
> program than a package as it is easier to build and run.
> Here is the one I've made from your test package:
>
>
> Is it correct for you ?
>
This works for me. Thanks.
>
> >
> > > procedure Remove (Dialog : in out Dialog_Type);
> > > -- Removes an element from the DOM, if the ID_Type is DOM_ID, the
> ID
> >
> > Removes the dialog?
> >
> > Yes, this maybe overkill. It cannot be dynamically managed in version 2
> but you can still remove it from the DOM (if I did it correctly) in cases
> where you want to manually manage stuff. Kind of a compromise. any of
> this stuff is up for debate/removal.
>
> In fact, I was pointing the comment, Shouldn't it be "-- Removes dialog
> from the DOM..."?
>
I used the same comment found in the Gnoga library for consistency.
Normally when I override something, I try to do that so it makes someone
look closer. I don't mind if you want to change it though.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Gnoga-list mailing list
Gnoga-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gnoga-list
