Schanzenbach, Martin transcribed 2.7K bytes: > Sounds good. > Note that the use of uncrustify is not mandatory. If you want to manually > follow the style > that is ok as well. So just pointing to uncrustify and the "rules"/coding > style is enough. > > Basically we should only use uncrustify to enforce our coding style in the > server. > Next year it might be another tool, but the coding style is that is important.
I do understand this, but pointing to the right tools or instructions also makes for a better onboarding experience. I've intended the tree now, if anyone has any complains on how it was handled there's one large commit to revert in the worst case. I don't think this was wrong, but in any case I'll continue with my work tomorrow. Thanks! > > On 8. Sep 2019, at 14:26, N <[email protected]> wrote: > > > > Christian Grothoff transcribed 2.6K bytes: > >> I agree, we should have a server-side hook that declines commits if the > >> C files in src/ would change under the formatter. ng0: can you > >> draft/test such a hook on git.taler.net? Once it works, I can deploy it > >> on git.gnunet.org. > >> > >> On 9/8/19 1:37 PM, Schanzenbach, Martin wrote: > >>> This is news to me, too. That being said, I would prefer if the commit > >>> would simply be rejected if not > >>> conforming (i.e. if running the formatter results in a different output). > >>> I would hate it if the commited > >>> code != my local copy after the push. > >> > > > > > > Okay, so this is what I will do (just to give you a sense of time): > > > > now: uncrustify the entire tree of gnunet's c/h files. remove clang-format > > from .dir-locals.el. > > still wonder about and accepting documentation for how to integrate > > this other than telling > > everyone just to use uncrustify somehow (the one good thing about > > clang-format was that it > > required almost 0 documentation). > > tomorrow/next week: draft the hook, etc >
signature.asc
Description: PGP signature
_______________________________________________ GNUnet-developers mailing list [email protected] https://lists.gnu.org/mailman/listinfo/gnunet-developers
