I pushed my patches to https://github.com/amanshaikh75/gobgp/tree/zapi_version_5
Essentially I created a zapi_version_5 branch from your zclient-Enable_to_request_MPLS_label_range branch and added support for ZAPI version 5 and VRF_LABEL message in particular. aman -----Original Message----- From: Iwase Yusuke [mailto:iwase.yusu...@gmail.com] Sent: Tuesday, February 27, 2018 7:20 PM To: SHAIKH, AMAN (AMAN) <asha...@research.att.com> Cc: gobgp-devel@lists.sourceforge.net Subject: Re: FW: [GoBGP-devel] MPLS label issue with VPNv4 routes Hi Aman, I remember when FRR version 2.x and 3.x, the ZAPI didn't keep the backward compatibility even if the version of ZAPI is the same (version 4).... > ZAPI version 5 is not backwards-compatible with version 4. The header now > uses > 32-bit VRF-IDs instead of 16-bit. The message types have changed. I > had to > spend about a day adding support for ZAPI 5, and it's not > complete. I have > tried to keep the support for version 4 (and 3) intact. > If you want I can push > my changes to my github account, so that you can > look at them. Let me know. Thank you for your explanation! Yeah, it is very interesting for me! Could you share us your patches? Also, how about discussing this topic on (a new) GitHub issue? Thread of this topic had become long, and I guess GitHub issue is more easier for GoBGP users to find this topic. Thanks, Iwase On 2018年02月27日 23:53, SHAIKH, AMAN (AMAN) wrote: > > I understand your anxiety. ZAPI version 5 is not backwards-compatible with > version 4. The header now uses 32-bit VRF-IDs instead of 16-bit. The message > types have changed. I had to spend about a day adding support for ZAPI 5, and > it's not complete. I have tried to keep the support for version 4 (and 3) > intact. If you want I can push my changes to my github account, so that you > can look at them. Let me know. > > thx > aman > > > -----Original Message----- > From: Iwase Yusuke [mailto:iwase.yusu...@gmail.com] > Sent: Monday, February 26, 2018 7:17 PM > To: SHAIKH, AMAN (AMAN) <asha...@research.att.com> > Cc: gobgp-devel@lists.sourceforge.net > Subject: Re: FW: [GoBGP-devel] MPLS label issue with VPNv4 routes > > Hi Aman, > > > Yes, to use ZEBRA_VRF_LABEL, you will have to use 'master' branch. This > > version uses ZAPI version 5. > > Thanks for your information! > > Hmmmm... just my anxiety... > When I implemented the FRR/Zebra support (based on the Quagga/Zebra > integration), I had some compatibility problems of the ZAPI messages. Along > with the update of FRR, the ZAPI message structure was changed without the > backward compatibility, so I dropped to support FRR version 2.x. Similar to > this problem, I'm worried if the ZAPI version 5 will be changed unexpectedly > near future (version 5 structure is not yet stable?)... > > Thanks, > Iwase > > On 2018年02月27日 00:51, SHAIKH, AMAN (AMAN) wrote: >> >> Hi Iwase, >> >> Yes, to use ZEBRA_VRF_LABEL, you will have to use 'master' branch. This >> version uses ZAPI version 5. >> >> aman >> >> -----Original Message----- >> From: Iwase Yusuke [mailto:iwase.yusu...@gmail.com] >> Sent: Sunday, February 25, 2018 6:56 PM >> To: SHAIKH, AMAN (AMAN) <asha...@research.att.com> >> Cc: gobgp-devel@lists.sourceforge.net >> Subject: Re: [GoBGP-devel] MPLS label issue with VPNv4 routes >> >> Hi Aman, >> >> Sounds great! >> >> To use the ZEBRA_VRF_LABEL command, which version of FRR is required? >> "stable/3.0" branch, GoBGP currently supports only FRR version 3.x, still >> uses the ZAPI version 4, then we need to use "dev/4.0" or "master"? >> >> Thanks, >> Iwase >> >> >> >> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ gobgp-devel mailing list gobgp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gobgp-devel
