Hi Fujita I think that ffr continues to keep changing the ZAPI in the way. That's the right thing for them. But I don't think that keeping up with the changes of ZAPI is the right thing for GoBGP. It's endless waste of resource.
I think that GoBGP could support one version that major distributions like Ubuntu lts but someone needs a cutting-edge zebra feature, he should use ffr. --> I understand it's hard for GoBGP to keep track of yet-unstable ZAPI version of FRR/Zebra. However, when FRR comes with its next release, I am hoping that the ZAPI version 5 would be stable. Will GoBGP add support for ZAPI version 5 at that point? thanks, aman -----Original Message----- From: FUJITA Tomonori [mailto:fujita.tomon...@gmail.com] Sent: Tuesday, February 27, 2018 10:17 PM To: gobgp-devel@lists.sourceforge.net Cc: SHAIKH, AMAN (AMAN) <asha...@research.att.com> Subject: Re: [GoBGP-devel] FW: MPLS label issue with VPNv4 routes Hi, 2018-02-28 9:19 GMT+09:00 Iwase Yusuke <iwase.yusu...@gmail.com>: > Hi Aman, > > I remember when FRR version 2.x and 3.x, the ZAPI didn't keep the > backward compatibility even if the version of ZAPI is the same (version 4).... > >> ZAPI version 5 is not backwards-compatible with version 4. The header >> now I think that ffr continues to keep changing the ZAPI in the way. That's the right thing for them. But I don't think that keeping up with the changes of ZAPI is the right thing for GoBGP. It's endless waste of resource. I think that GoBGP could support one version that major distributions like Ubuntu lts but someone needs a cutting-edge zebra feature, he should use ffr. >> uses >> 32-bit VRF-IDs instead of 16-bit. The message types have changed. I >> had to spend about a day adding support for ZAPI 5, and it's not >> complete. I have tried to keep the support for version 4 (and 3) >> intact. If you want I can push my changes to my github account, so >> that you can look at them. Let me know. > > Thank you for your explanation! > > Yeah, it is very interesting for me! Could you share us your patches? > Also, how about discussing this topic on (a new) GitHub issue? Thread > of this topic had become long, and I guess GitHub issue is more easier > for GoBGP users to find this topic. > > Thanks, > Iwase > > > > On 2018年02月27日 23:53, SHAIKH, AMAN (AMAN) wrote: >> >> >> I understand your anxiety. ZAPI version 5 is not backwards-compatible >> with version 4. The header now uses 32-bit VRF-IDs instead of 16-bit. >> The message types have changed. I had to spend about a day adding >> support for ZAPI 5, and it's not complete. I have tried to keep the >> support for version 4 (and >> 3) intact. If you want I can push my changes to my github account, so >> that you can look at them. Let me know. >> >> thx >> aman >> >> >> -----Original Message----- >> From: Iwase Yusuke [mailto:iwase.yusu...@gmail.com] >> Sent: Monday, February 26, 2018 7:17 PM >> To: SHAIKH, AMAN (AMAN) <asha...@research.att.com> >> Cc: gobgp-devel@lists.sourceforge.net >> Subject: Re: FW: [GoBGP-devel] MPLS label issue with VPNv4 routes >> >> Hi Aman, >> >> > Yes, to use ZEBRA_VRF_LABEL, you will have to use 'master' branch. >> This > version uses ZAPI version 5. >> >> Thanks for your information! >> >> Hmmmm... just my anxiety... >> When I implemented the FRR/Zebra support (based on the Quagga/Zebra >> integration), I had some compatibility problems of the ZAPI messages. >> Along with the update of FRR, the ZAPI message structure was changed >> without the backward compatibility, so I dropped to support FRR >> version 2.x. Similar to this problem, I'm worried if the ZAPI version >> 5 will be changed unexpectedly near future (version 5 structure is not yet >> stable?)... >> >> Thanks, >> Iwase >> >> On 2018年02月27日 00:51, SHAIKH, AMAN (AMAN) wrote: >>> >>> >>> Hi Iwase, >>> >>> Yes, to use ZEBRA_VRF_LABEL, you will have to use 'master' branch. >>> This version uses ZAPI version 5. >>> >>> aman >>> >>> -----Original Message----- >>> From: Iwase Yusuke [mailto:iwase.yusu...@gmail.com] >>> Sent: Sunday, February 25, 2018 6:56 PM >>> To: SHAIKH, AMAN (AMAN) <asha...@research.att.com> >>> Cc: gobgp-devel@lists.sourceforge.net >>> Subject: Re: [GoBGP-devel] MPLS label issue with VPNv4 routes >>> >>> Hi Aman, >>> >>> Sounds great! >>> >>> To use the ZEBRA_VRF_LABEL command, which version of FRR is required? >>> "stable/3.0" branch, GoBGP currently supports only FRR version 3.x, >>> still uses the ZAPI version 4, then we need to use "dev/4.0" or "master"? >>> >>> Thanks, >>> Iwase >>> >>> >>> > > > ---------------------------------------------------------------------- > -------- Check out the vibrant tech community on one of the world's > most engaging tech sites, Slashdot.org! > https://urldefense.proofpoint.com/v2/url?u=http-3A__sdm.link_slashdot&; > d=DwIFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=I_2UmL83HQfOEoCVzChS_fiJdy8vxHF4_J > M0AhcKK4Y&m=tV9lxg7oNRGMTEcEpV0zX-WeTZSYs2s6ApfSkLF9RWc&s=rIJsDBfAze5D > vdSXjAhznqPN6wfV8iNnmbFoAvUtGYE&e= > _______________________________________________ > gobgp-devel mailing list > gobgp-devel@lists.sourceforge.net > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge > .net_lists_listinfo_gobgp-2Ddevel&d=DwIFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r= > I_2UmL83HQfOEoCVzChS_fiJdy8vxHF4_JM0AhcKK4Y&m=tV9lxg7oNRGMTEcEpV0zX-We > TZSYs2s6ApfSkLF9RWc&s=0n-NDrbWGd1H4La-yyQ4fHaT9Pw1gdD44C7vHAW48sY&e= ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ gobgp-devel mailing list gobgp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gobgp-devel
