Bad things I noticed while reading through some gobo scripts :) (the versions from CVS.) I could make patches for these (probably). (of course I might be mistaken about some of them, so I just send this :)
DevelScripts/bin/PutRecipe It sets compile_version to 1.8.2 even if a _later_ version was specified in the recipe! I don't know how to scriptedly compare version strings that look like this, though... Scripts/bin/GrepReplace The usage information is confusing. For -R, the usage is just GrepReplace -R <from> <to> (in the code, shouldn't the Args_To_Array be _inside_ the not---recursive case if this is true?), and it starts from the current directory, which is not explained by the help. If directories are provided with -R, I think it should instead use them instead of the current one, similarly to grep -r. Then the -R help could read "Perform change recursively in all files (or the current directory if no files are named)." The implementation could be faster and admit : and \ in filenames if: The greps took -l as well as their existing flags, the '| cut -f 1 -d:' was removed, and 'read file' was 'read -r file'. Isn't grep -r pat * .[^.]* the same as grep -r pat . ? Also what's supposed to happen with no files named, and not -R? Current version will read from stdin and get very confused. I think GrepReplace should then just behave like the 'sed' from stdin to stdout (unless GrepReplace should give an error at such usage instead). Something like a --no-backup option might be nice... Scripts/Functions/GoboLinux The """ ... """ around the python code is a little misleading since it's no better than one double-quote at the beginning and end. Bypass_Superuser should very probably use "$@", not $*. re: sudo_validate="sudo -u `whoami` true", running that does not ask me for my password, nor validate me to sudo to root for five minutes. sudo_validate="sudo -v" seems to work better. As far as I can tell from experimenting, then $sudo_validate doesn't trigger aliases in bash (since old alias sudo=Sudo which needs to be avoided), but these also should work: sudo_validate="`which sudo` -v" (relies on `which`) sudo_validate="/bin/sudo -v" (relies on location of /bin - changes original behavior) sudo_validate="command sudo -v" (my favorite. just relies on a shell that has 'command', which includes bash.) Scripts/bin/RemoveBroken doesn't respond nicely to --help. _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
