On 7/18/07, Isaac Dupree <[EMAIL PROTECTED]> wrote: > Bad things I noticed while reading through some gobo scripts :) (the > versions from CVS.) I could make patches for these (probably). (of > course I might be mistaken about some of them, so I just send this :) > > DevelScripts/bin/PutRecipe > It sets compile_version to 1.8.2 even if a _later_ version was specified > in the recipe! I don't know how to scriptedly compare version strings > that look like this, though...
Ah, that's my fault. The idea was to always keep that version up to date with Compile releases, but sometimes I just forget about doing that. Please feel free to update it to the last one or, if you have a better suggestion on how to keep that synchronized, just let me know. > Scripts/bin/GrepReplace You're probably right, but I haven't had a chance to look at it. Might be better to wait for someone's else review. > Scripts/Functions/GoboLinux > The """ > ... > """ around the python code is a little misleading since it's no better > than one double-quote at the beginning and end. Probably coding style.. there might be other patterns like this in another python scripts. I don't mind in adopting a single one (in fact it could be a good thing to document, just like the template for shell scripts). > Bypass_Superuser should very probably use "$@", not $*. Did you run into some problem with $*? > Scripts/bin/RemoveBroken doesn't respond nicely to --help. Oh, that's easy to be changed. Feel free to patch it :) -- Lucas powered by /dev/dsp _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
