On 7/20/07, Lucas C. Villa Real <[EMAIL PROTECTED]> wrote: > On 7/18/07, Isaac Dupree <[EMAIL PROTECTED]> wrote: > > Bad things I noticed while reading through some gobo scripts :) (the > > versions from CVS.) I could make patches for these (probably). (of > > course I might be mistaken about some of them, so I just send this :) > > > > DevelScripts/bin/PutRecipe > > It sets compile_version to 1.8.2 even if a _later_ version was specified > > in the recipe! I don't know how to scriptedly compare version strings > > that look like this, though... > > Ah, that's my fault. The idea was to always keep that version up to > date with Compile releases, but sometimes I just forget about doing > that. Please feel free to update it to the last one or, if you have a > better suggestion on how to keep that synchronized, just let me know.
No, it shouldn't force the latest Compile version every time there! Ideally this should contain the lowest version of Compile needed for a recipe to work. Since it's impractical to verify that number, the number used by the recipe author is the "lowest verified number" and must be respected. I see you've been tweaking recipes in PutRecipe to change their syntax, but that shouldn't be necessary anymore (all recipes in the store use the new format, and even then your tweaks of compile_version should use the lowest possible number and never clobber the recipe's number if it's higher). > > Bypass_Superuser should very probably use "$@", not $*. > > Did you run into some problem with $*? This kind of change should be triple-checked for correctness. It's dangerous to apply the "$@" rule of thumb in every case. Unless you run into a real problem, don't change it. I don't remember exactly where, but there are locations in Scripts where $* is really the right pattern to use. -- Hisham _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
