http://codereview.appspot.com/11948/diff/1/2
File doc/html/compiledModuleFormat/index.html (right):
http://codereview.appspot.com/11948/diff/1/2#newcode2
Line 2: -- Copyright (C) 2008 Google Inc.
2009
http://codereview.appspot.com/11948/diff/1/2#newcode25
Line 25: <script type="text/javascript"
src="../common/prettify.js"></script>
Do we have two version of prettify? There's one under
third_party/js/prettify
http://codereview.appspot.com/11948/diff/1/2#newcode103
Line 103: code: function(___, IMPORTS___) { ... },
Can we name this using a verb as per method naming conventions?
http://codereview.appspot.com/11948/diff/1/2#newcode107
Line 107: manifest: { ...},
- trailing ,
http://codereview.appspot.com/11948/diff/1/2#newcode118
Line 118: <td>The anonymous function representing the module, as
before.</td>
Does the signature change in any way? Is the return value significant?
Does it depend differently on any cajita.js machinery?
http://codereview.appspot.com/11948/diff/1/2#newcode122
Line 122: <td><code class="prettyprint">sha1sum</code></td>
Do we want the name of a particular hashing algorithm in the property
name? SHA-1 will be replaced at some point by a new hash algo.
http://codereview.appspot.com/11948/diff/1/2#newcode133
Line 133: applications may only check it for equality.</td>
Comparable to what? Specifically, is it comparable to any value
exported by cajita.js?
http://codereview.appspot.com/11948/diff/1/2#newcode141
Line 141: absent.</td>
This sounds like it has the potential to be larger than all the rest of
the data in the module definition. Can we give containers enough room
to be able to lazily fetch it?
http://codereview.appspot.com/11948/diff/1/2#newcode149
Line 149: the <code>cajita.manifest()</code> function.</td>
What is in the manifest? Is the cajita.manifest method new?
http://codereview.appspot.com/11948