Good to see this!


http://codereview.appspot.com/11948/diff/1/2
File doc/html/compiledModuleFormat/index.html (right):

http://codereview.appspot.com/11948/diff/1/2#newcode111
Line 111: <p>The following are the standard keys:</p>
Should also include an enumeration of those varnames that the module
obtains from IMPORTS___ (which will be those vars used freely in the
original source).

Perhaps this should include the assumed-safe static path info that we're
currently passing to readImport?

http://codereview.appspot.com/11948/diff/1/2#newcode123
Line 123: <td><em>required</em></td>
The sha1sum should not be required. We also shouldn't use sha1. I do not
yet know of a consensus of what to use instead.

http://codereview.appspot.com/11948/diff/1/2#newcode132
Line 132: translator which emitted this module. This is an opaque value;
Strings are not opaque, and it seems meaningless to require apps to
check them only for equality. I also think equality is more severe than
you want anyway.

http://codereview.appspot.com/11948

Reply via email to