http://codereview.appspot.com/11948/diff/8/9
File doc/html/compiledModuleFormat/index.html (right):

http://codereview.appspot.com/11948/diff/8/9#newcode118
Line 118: <td><code class="prettyprint">execute</code></td>
Based on reading the html without the css, you should add a
   valign="top"
to your left column headings. I don't know if this is really needed
given your css.

http://codereview.appspot.com/11948/diff/8/9#newcode135
Line 135: <td><code class="prettyprint">cajoledDate</code></td>
Why is the cajoledDate required? I think it should be optional.

http://codereview.appspot.com/11948/diff/8/9#newcode160
Line 160: literal containing the text of the file. The text is escaped
such that
Even initially, I think we should somehow make an allowance for the
cajoler to instead provide URLs from which the original source can be
fetched, rather than shipping the original source directly.

http://codereview.appspot.com/11948/diff/8/9#newcode180
Line 180: the <code>cajita.manifest()</code> function.</td>
calling the caja.manifest() function [with a static JSON literal].

It would not work to call it with an expression that needs to be
evaluated, since the whole point is to enable the manifest to be
obtained without (or prior to) calling the module function.

http://codereview.appspot.com/11948/diff/8/9#newcode185
Line 185: <div class="note">TODO: Move support for the "assumed-safe
static path" information
The right place for this is in the variable metadata above, where you
already say "corresponding value is some JSON data providing
meta-information about the module's expectations regarding that
variable." The assumed-safe static path info is such an expectation.

http://codereview.appspot.com/11948

Reply via email to