http://codereview.appspot.com/89073/diff/10/1009
File src/com/google/caja/plugin/templates/TemplateCompiler.java (right):
http://codereview.appspot.com/89073/diff/10/1009#newcode277
Line 277: if (!checkLegalSuffix(value, pos)) { return; }
It would be nice to add a nearby comment referring to
http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.2, which I
presume is the relevant legal basis.
http://codereview.appspot.com/89073/diff/10/1009#newcode392
Line 392: private boolean checkLegalSuffix(String value, FilePosition
pos) {
Why are there not checkLegalSuffix and checkLegalSuffixes, for the
one-valued and many-valued cases, respectively, similar to
checkRestrictedName and checkRestrictedNames?
http://codereview.appspot.com/89073/diff/10/1007
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java
(right):
http://codereview.appspot.com/89073/diff/10/1007#newcode302
Line 302: public void test1057ClassNames() throws Exception {
1057??
http://codereview.appspot.com/89073/diff/10/1007#newcode313
Line 313: htmlFragment(fromString("<div></div>")),
Right. It's ok that the entire "class" attribute is rejected, but the
error message should complain about the specific part of it that failed,
i.e., "bad__" rather than "bad__ ok". See comment in
TemplateCompiler.java.
http://codereview.appspot.com/89073
