On 2009/07/07 16:41:01, ihab.awad wrote:
http://codereview.appspot.com/89073/diff/10/1009
File src/com/google/caja/plugin/templates/TemplateCompiler.java
(right):
http://codereview.appspot.com/89073/diff/10/1009#newcode392
Line 392: private boolean checkLegalSuffix(String value, FilePosition
pos) {
On 2009/07/07 12:53:53, felix8a wrote:
> it'll just change what error message you get.
Yep, true.
> I'll fix it both here and in domita.js
There's no reason to fix domita.js. It's okay for the domita.js checks
to be
more brief and less "compiler"-like, as long as all the Java cajoler
stuff is
internally consistent and all the run-time Domita stuff is internally
consistent. Fixing domita.js would imply changing a bunch of stuff
that's
already there that already works.
ok, how about I rename it to checkLegalSuffixes and omit
checkLegalSuffix?
I'd like to keep the code structurally similar to domita.js, because I
think
the similarity makes it easier to verify they have similar behavior.
http://codereview.appspot.com/89073
