http://codereview.appspot.com/89073/diff/10/1009
File src/com/google/caja/plugin/templates/TemplateCompiler.java (right):

http://codereview.appspot.com/89073/diff/10/1009#newcode392
Line 392: private boolean checkLegalSuffix(String value, FilePosition
pos) {
On 2009/07/06 22:27:53, ihab.awad wrote:
Why are there not checkLegalSuffix and checkLegalSuffixes, for the
one-valued
and many-valued cases, respectively, similar to checkRestrictedName
and
checkRestrictedNames?

mainly because I'm mimicking what domita.js does.
and since checkRestrictedName doesn't allow spaces in the value,
adding a single-value checkLegalSuffix won't change what
values are legal, it'll just change what error message you get.

but I guess it's better to not rely on the coupling.  ok, I'll fix it
both here and in domita.js

http://codereview.appspot.com/89073

Reply via email to