http://codereview.appspot.com/89076/diff/4001/3005
File src/com/google/caja/plugin/html-emitter.js (right):

http://codereview.appspot.com/89076/diff/4001/3005#newcode252
Line 252: var tagAttr = el.tagName.toLowerCase() + ':' + attrName;
Can we use the lower casing function from domita here?  So that on
Turkish browsers, SCRIPT doesn't lower-case to scrıpt.

Rhino at least has this problem:
  $ java -Duser.language=tr -Duser.region=TR \
    -jar third_party/java/rhino/js.jar
  Rhino 1.7 release 1 2008 03 06
  js> 'SCRIPT'.toLowerCase()
  scr?pt
  js> 'script'.toUpperCase()
  SCR?PT
but this may because Rhino delegating to Java's busted
String.to{Upper,Lower}Case

http://codereview.appspot.com/89076/diff/4001/3005#newcode254
Line 254: || html4.ATTRIBS['*:' + attrName] === html4.atype.SCRIPT) {
The second clause only applies if html4.ATTRIBS[tagAttr] is undefined,
right?
I don't think this matters in practice, but it is probably worth a
comment.

http://codereview.appspot.com/89076

Reply via email to