LGTM


http://codereview.appspot.com/89076/diff/6007/7010
File src/com/google/caja/plugin/html-emitter.js (right):

http://codereview.appspot.com/89076/diff/6007/7010#newcode184
Line 184: while (nConsumed < detached.length) {
On 2009/08/12 08:05:17, felix8a wrote:
On 2009/08/11 22:52:28, MikeSamuel wrote:
> Why does this condition change?

last-ditch recovery in case we walk off the end of detached without
finding
limit.  I don't know of a case where it might happen, but I didn't
expect this
IE weirdness either.  the argument in my mind is fail-fast vs
user-friendly
recovery, and I've flipped back and forth several times.

Fair enough.  Please comment the condition so that a maintainer won't
puzzle over what case might cause it to be false early.

http://codereview.appspot.com/89076

Reply via email to