On Sat, Sep 25, 2010 at 8:28 PM, Mark S. Miller <[email protected]> wrote:
> On Thu, Sep 23, 2010 at 9:59 PM, <[email protected]> wrote: > >> >> http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode751 >> src/com/google/caja/es53.js:751: // Is there any reason even to log >> these? They are many, and >> On 2010/09/23 20:56:02, metaweta wrote: >> >>> There shouldn't be any; where are you seeing them? I was getting >>> >> errors due to >> >>> accidentally taming something in two ways, so I put this in. >>> >> >> I don't remember. I'll instrument and re-run until I reproduce this. Or >> I'll revert. > > > The reason you weren't seeing these dups was that your previous line > fn.f___ !== fn.apply > was buggy. After I corrected to > fn.f___ === fn.apply > I saw the error. When I change the error report to simply logging dups, I > see trace shown below. > > The other possibility is that I misunderstand the purpose of your equality test and that it was not originally buggy. In which case my "fix" created the problem. Please advise. -- Cheers, --MarkM
