https://codereview.appspot.com/6827077/diff/1/build.xml File build.xml (right):
https://codereview.appspot.com/6827077/diff/1/build.xml#newcode990 build.xml:990: <input file="${third_party}/js/escodegen/escodegen.js" jslint="false"/> Since these third-party files support the 'exports' pattern, we should use it in order to avoid crufting up the global environment. Place files before and after this group which create an 'exports' object (saving the old variable), let them load, then transfer the exports into the 'ses' module and restore the original 'exports' if any. https://codereview.appspot.com/6827077/diff/1/build.xml#newcode1016 build.xml:1016: <input file="${src.caja}/ses/mitigateGotchas.js"/> Ditto. https://codereview.appspot.com/6827077/diff/1/tests/com/google/caja/plugin/es53-test-gotchas-guest.html File tests/com/google/caja/plugin/es53-test-gotchas-guest.html (right): https://codereview.appspot.com/6827077/diff/1/tests/com/google/caja/plugin/es53-test-gotchas-guest.html#newcode17 tests/com/google/caja/plugin/es53-test-gotchas-guest.html:17: <div class="testcontainer" id="testTopLevel" There are already some tests for "assignments show up on window which is the global environment" (disabled in ES5 mode) in es53-test-domado-dom-guest.html. We shouldn't have tests in two places. Perhaps these tests and those should be moved to es53-test-language-guest.html? https://codereview.appspot.com/6827077/diff/1/tests/com/google/caja/plugin/es53-test-gotchas-guest.html#newcode36 tests/com/google/caja/plugin/es53-test-gotchas-guest.html:36: debugger; cruft https://codereview.appspot.com/6827077/diff/1/tests/com/google/caja/plugin/es53-test-gotchas-guest.html#newcode53 tests/com/google/caja/plugin/es53-test-gotchas-guest.html:53: jsunitRegisterIf(inES5Mode, no testcontainer to match this test https://codereview.appspot.com/6827077/
