https://codereview.appspot.com/6827077/diff/18001/src/com/google/caja/ses/exportsToSES.js File src/com/google/caja/ses/exportsToSES.js (right):
https://codereview.appspot.com/6827077/diff/18001/src/com/google/caja/ses/exportsToSES.js#newcode26 src/com/google/caja/ses/exportsToSES.js:26: ses.generate = exports.generate; Maybe stuff these on a sub-object of some sort (e.g. ses._modules = {}), given that these are not part of the public interface of SES or even designed to be cap-safe modules, but have inviting names? I also think it is worth a comment that we are squashing together the exports of three modules (i.e. works-by-accident). https://codereview.appspot.com/6827077/diff/18001/src/com/google/caja/ses/mitigateGotchas.js File src/com/google/caja/ses/mitigateGotchas.js (right): https://codereview.appspot.com/6827077/diff/18001/src/com/google/caja/ses/mitigateGotchas.js#newcode24 src/com/google/caja/ses/mitigateGotchas.js:24: * Note the parse tree manipulated in this file uses the SpiderMonkey "Note that the parse tree" https://codereview.appspot.com/6827077/diff/18001/src/com/google/caja/ses/whitelist.js File src/com/google/caja/ses/whitelist.js (right): https://codereview.appspot.com/6827077/diff/18001/src/com/google/caja/ses/whitelist.js#newcode145 src/com/google/caja/ses/whitelist.js:145: inES5Mode: t This doesn't belong in the definition of SES as it is a test suite thing. Make it a global explicitly added to the environment by the test driver instead. https://codereview.appspot.com/6827077/diff/18001/tests/com/google/caja/plugin/es53-test-domado-dom-guest.html File tests/com/google/caja/plugin/es53-test-domado-dom-guest.html (right): https://codereview.appspot.com/6827077/diff/18001/tests/com/google/caja/plugin/es53-test-domado-dom-guest.html#newcode2190 tests/com/google/caja/plugin/es53-test-domado-dom-guest.html:2190: // properly. Obsolete comment. https://codereview.appspot.com/6827077/diff/18001/tests/com/google/caja/plugin/es53-test-gotchas-guest.html File tests/com/google/caja/plugin/es53-test-gotchas-guest.html (right): https://codereview.appspot.com/6827077/diff/18001/tests/com/google/caja/plugin/es53-test-gotchas-guest.html#newcode30 tests/com/google/caja/plugin/es53-test-gotchas-guest.html:30: <div class="testcontainer" id="testTypeOf"></div> Move this to immediately before the testTypeOf code (splitting the script block). https://codereview.appspot.com/6827077/diff/18001/tests/com/google/caja/plugin/es53-test-gotchas-guest.html#newcode32 tests/com/google/caja/plugin/es53-test-gotchas-guest.html:32: <br> cruft https://codereview.appspot.com/6827077/
