LGTM
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode3503
src/com/google/caja/ses/repairES5.js:3503: canRepair: false, // Not
repairable
Since one of your categories below is "// Not repairable without
rewriting", perhaps this and similar "Not repairable"s should be marked
with that instead?
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode3936
src/com/google/caja/ses/repairES5.js:3936: canRepair: false, // Not
attempting a repair
I don't understand what information "Not attempting a repair" adds. Why
are we not attempting a repair?
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode4014
src/com/google/caja/ses/repairES5.js:4014: canRepair: false, // Not
repairable without rewriting
Actually not. All that would be required is a verifying parse. If we see
any syntax beyond what we want to recognize, including E4X, we'd reject.
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode4027
src/com/google/caja/ses/repairES5.js:4027: // 'repair' sets a flag to
take advantage of it.
All true. But additionally, even if we did want to repair this, it isn't
repairable without a rewrite.
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode4292
src/com/google/caja/ses/repairES5.js:4292: canRepair: false, // Not
repairable
... without a verifying parse.
https://codereview.appspot.com/13242047/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
