https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode3503
src/com/google/caja/ses/repairES5.js:3503: canRepair: false, // Not
repairable
On 2013/08/27 20:53:52, MarkM wrote:
Since one of your categories below is "// Not repairable without
rewriting",
perhaps this and similar "Not repairable"s should be marked with that
instead?
Done.
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode3936
src/com/google/caja/ses/repairES5.js:3936: canRepair: false, // Not
attempting a repair
On 2013/08/27 20:53:52, MarkM wrote:
I don't understand what information "Not attempting a repair" adds.
Why are we
not attempting a repair?
I don't know! Do you?
What I didn't want to do was break the pattern of _every_ canRepair:
false having a comment of some sort (so that the next person to
cut-and-paste a new problem record is likely to include one in theirs).
Do you have a suggestion for a more informative comment (that is not a
TODO)?
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode4014
src/com/google/caja/ses/repairES5.js:4014: canRepair: false, // Not
repairable without rewriting
On 2013/08/27 20:53:52, MarkM wrote:
Actually not. All that would be required is a verifying parse. If we
see any
syntax beyond what we want to recognize, including E4X, we'd reject.
Done.
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode4292
src/com/google/caja/ses/repairES5.js:4292: canRepair: false, // Not
repairable
On 2013/08/27 20:53:52, MarkM wrote:
... without a verifying parse.
Done.
https://codereview.appspot.com/13242047/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
