https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/13242047/diff/1/src/com/google/caja/ses/repairES5.js#newcode3936
src/com/google/caja/ses/repairES5.js:3936: canRepair: false, // Not
attempting a repair
On 2013/08/27 22:29:46, kpreid2 wrote:
On 2013/08/27 20:53:52, MarkM wrote:
> I don't understand what information "Not attempting a repair" adds.
Why are we
> not attempting a repair?
I don't know! Do you?
I do, but I don't have an informative and non-pejorative short phrase.
If a platform suffers from this bug, it shows they take frozenness so
unseriously that it is not worth attempting a repair since we'll
probably be unsafe in other ways we don't know about anyway. Perhaps a
more polite and still accurate point is that we've never encountered an
actual platform that both suffered from this bug and was overall
fixable.
What I didn't want to do was break the pattern of _every_ canRepair:
false
having a comment of some sort (so that the next person to
cut-and-paste a new
problem record is likely to include one in theirs).
Do you have a suggestion for a more informative comment (that is not a
TODO)?
How about
// No known repairable platforms with this bug, so not worth repairing
https://codereview.appspot.com/13242047/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
