This change still needs review of its not-SES parts, I assume.
https://codereview.appspot.com/12801043/diff/32001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/12801043/diff/32001/src/com/google/caja/ses/repairES5.js#newcode3436
src/com/google/caja/ses/repairES5.js:3436: var
repair_TYPED_ARRAY_PROTOS_LOOK_UNFROZEN_wasApplied = false;
On 2013/10/11 00:17:49, MarkM wrote:
Since the test occurs first textually, please declare this variable
above the
test instead.
Done.
https://codereview.appspot.com/12801043/diff/32001/src/com/google/caja/ses/repairES5.js#newcode3454
src/com/google/caja/ses/repairES5.js:3454: // is used without startSES.)
On 2013/10/11 00:17:49, MarkM wrote:
More weird but more safe:
Add a ses.flag that startSES can use to communicate back to repairES5.
After
startSES freezes the primordials, it sets the flag. Here, the wrapper
function
would report freeze or not depending on whether the flag was set. Also
for
isFrozen below.
Done.
https://codereview.appspot.com/12801043/diff/32001/src/com/google/caja/ses/repairES5.js#newcode4501
src/com/google/caja/ses/repairES5.js:4501: // DOMException is poisonous
to WeakMaps on FF so we choose not to
On 2013/10/11 00:17:49, MarkM wrote:
I don't understand this comment.
Rewritten.
https://codereview.appspot.com/12801043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
