lgtm++ but please consider the comments.
https://codereview.appspot.com/12801043/diff/170001/src/com/google/caja/plugin/taming-membrane.js
File src/com/google/caja/plugin/taming-membrane.js (right):
https://codereview.appspot.com/12801043/diff/170001/src/com/google/caja/plugin/taming-membrane.js#newcode172
src/com/google/caja/plugin/taming-membrane.js:172: * copyUnmemoized
performs the analogous role.
It's confusing to me that "memoized" versus "unmemoized" is used as a
distinction in these functions even though memoization is dealt with
elsewhere.
I'd leave out the memoization stuff from comments and function names.
https://codereview.appspot.com/12801043/diff/170001/src/com/google/caja/plugin/taming-membrane.js#newcode247
src/com/google/caja/plugin/taming-membrane.js:247: function
copyUnmemoized(o, recursor) {
Anything that does not mention memoization -- e.g. "copyBulkDataType" or
"copyArrayAndFriends" or whatever -- would imho be better than
introducing the idea of memoization here.
https://codereview.appspot.com/12801043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
