https://codereview.appspot.com/12801043/diff/170001/src/com/google/caja/plugin/taming-membrane.js
File src/com/google/caja/plugin/taming-membrane.js (right):
https://codereview.appspot.com/12801043/diff/170001/src/com/google/caja/plugin/taming-membrane.js#newcode247
src/com/google/caja/plugin/taming-membrane.js:247: function
copyUnmemoized(o, recursor) {
On 2013/10/25 22:53:12, ihab.awad wrote:
Anything that does not mention memoization -- e.g. "copyBulkDataType"
or "copyArrayAndFriends" or whatever -- would imho be better than
introducing the idea of memoization here.
I don't particularly like copyUnmemoized myself, but I haven't come up
with something clearly better here.
The distinction we are actually making here is _builtin types which are
likely to be mutated_, which are not memoized for that reason. (Also
'and which can contain references', but that's incidental.) The fact
that they are both array-like is accidental. I have no good ideas for
names which convey this distinction, and your suggestions are pointing
at incidental rather than fundamental aspects.
'copyMutable' / 'copyImmutable' would be short and clear, but wrong
because Date and friends are not immutable; we're just acting as if they
are. How about 'copyTreatedMutable' / 'copyTreatedImmutable'?
https://codereview.appspot.com/12801043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
