https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html
File src/com/google/caja/ses/explicit.html (right):
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html#newcode156
src/com/google/caja/ses/explicit.html:156: (function() {
Please add an explanation of what this is testing for. Right now it just
logs a message that doesn't help the user know what it means.
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html#newcode168
src/com/google/caja/ses/explicit.html:168: var stack = 'nothing caught';
Unused variable? Were you meaning to test ses.getStack?
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html#newcode171
src/com/google/caja/ses/explicit.html:171: } catch (er) {
Odd variable name. Please use either 'e' or 'err', whichever is more
common in the codebase.
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html#newcode176
src/com/google/caja/ses/explicit.html:176: })();
}());
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repairES5.js#newcode4568
src/com/google/caja/ses/repairES5.js:4568: preSeverity:
severities.UNSAFE_SPEC_VIOLATION,
Please also add this to the set of acceptNoKnownExploitProblems in
caja.js. It qualifies since it doesn't violate the integrity of Caja
itself — it only affects illegal-in-ES5 code which, if it were to occur
in Caja's source, would be caught by our testing under other browsers.
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repairES5.js#newcode4571
src/com/google/caja/ses/repairES5.js:4571: sections: [],
Cite the section which prohibits functions inside blocks in strict mode.
https://codereview.appspot.com/43490045/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
