LGTM (given added comment as noted)
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html
File src/com/google/caja/ses/explicit.html (right):
https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explicit.html#newcode176
src/com/google/caja/ses/explicit.html:176: })();
On 2013/12/18 04:58:16, MarkM wrote:
On 2013/12/18 04:28:03, kpreid2 wrote:
> }());
Done. But why?
Because they should be consistent, and Crockford's opinion is that they
should be this way around, which is a good enough way to choose for me.
https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/explicit.html
File src/com/google/caja/ses/explicit.html (right):
https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/explicit.html#newcode171
src/com/google/caja/ses/explicit.html:171: ses.logger.info('Expected
error to test ses.getStack API: ', err);
On 2013/12/18 18:18:12, MarkM wrote:
The ses.logger installed by useHTMLLogger.js uses ses.getStack to
display the
stack, if any, associated with the err argument.
Please add that as a comment.
https://codereview.appspot.com/43490045/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
