https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/explicit.html
File src/com/google/caja/ses/explicit.html (right):
https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/explicit.html#newcode171
src/com/google/caja/ses/explicit.html:171: ses.logger.info('Expected
error to test ses.getStack API: ', err);
On 2013/12/18 18:03:32, kpreid2 wrote:
I still don't understand what this is doing. How is this testing
ses.getStack,
which is not used?
The ses.logger installed by useHTMLLogger.js uses ses.getStack to
display the stack, if any, associated with the err argument.
If this is about what I think it's about, stacks being lost when using
the Caja
API, then that was due to the taming membrane — there's no reason to
believe we
need to provide tools for investigating browsers' behavior (which is
what
explicit.html is about, yes?) here.
The issue is the non-membrane behavior of ses.getStack, which does
indeed vary between browsers, and which I want to start improving. For
example, on Safari it currently shows no stack when it could.
https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/repairES5.js#newcode2872
src/com/google/caja/ses/repairES5.js:2872: '(function() {\n' +
On 2013/12/18 18:03:32, kpreid2 wrote:
indent 2 more spaces (both outer and quoted code indent is wrong
otherwise)
Done.
https://codereview.appspot.com/43490045/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
