https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/WeakMap.js
File src/com/google/caja/ses/WeakMap.js (right):
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/WeakMap.js#newcode194
src/com/google/caja/ses/WeakMap.js:194: // } catch (e) {}
On 2014/01/29 22:03:24, MarkM wrote:
no it isn't. What happens if the try block doesn't throw but the test
within the
try block is false?
Oops, I wasn't actually thinking about the problem. That would be a new
symptom. Done.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js
File src/com/google/caja/ses/repair-framework.js (right):
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode39
src/com/google/caja/ses/repair-framework.js:39: *
<dt>MAGICAL_UNICORN</dt><dd>Unachievable magical mode used for testing.
On 2014/01/29 22:03:24, MarkM wrote:
Missing </dd>
Done for consistency, but please note that omitting </dd> (and </dt> and
</li>) is permitted and unambiguous.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode183
src/com/google/caja/ses/repair-framework.js:183: callback(objAsMap[key],
key, self);
On 2014/01/29 22:03:24, MarkM wrote:
Shouldn't the "key" argument instead be the substring of key without
the final
'$'?
Fixed and tested.
https://codereview.appspot.com/54450044/diff/20001/src/com/google/caja/ses/WeakMap.js
File src/com/google/caja/ses/WeakMap.js (right):
https://codereview.appspot.com/54450044/diff/20001/src/com/google/caja/ses/WeakMap.js#newcode243
src/com/google/caja/ses/WeakMap.js:243: tests: []
On 2014/01/29 22:03:24, MarkM wrote:
Isn't think another empty test section that should eventually have
tests, and
therefore should have todos?
Done.
https://codereview.appspot.com/54450044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
