New snapshot.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js
File src/com/google/caja/ses/repair-framework.js (right):
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode302
src/com/google/caja/ses/repair-framework.js:302: var postTestKludge =
undefined;
On 2014/01/30 20:17:18, MarkM wrote:
Stale name?
No, this is a kludge in the conventional sense -- I labeled it that way
to flag that it ought to be gotten rid of somehow.
Actually, you made me spot a problem: it was never actually _used_.
Function extraRepair in repairES5.js should have been registered as the
postTestKludge. Done.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode310
src/com/google/caja/ses/repair-framework.js:310: // using direct
hasOwnProperty is safe as problem ID syntax is restricted
On 2014/01/30 20:17:18, MarkM wrote:
What does "restricted" mean here?
Restricted to syntax which does not collide with Object.prototype
properties, namely uppercase and underscores.
Instead of explaining this in more detail, I've changed the code to use
Object.prototype.hasOwnProperty.call because there's no good reason not
to, and deleted the comment.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode345
src/com/google/caja/ses/repair-framework.js:345: // Lock in the failure
if any since it is no longer yetToRepair
On 2014/01/30 20:17:18, MarkM wrote:
It isn't quite yet no longer yetToRepair, since you don't delete it
until the
next statement below.
Rephrased.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode365
src/com/google/caja/ses/repair-framework.js:365: // TODO(kpreid): Need
to insert repair attempted statuses here
On 2014/01/30 20:17:18, MarkM wrote:
Write here clarification u just told me verbally
Done.
https://codereview.appspot.com/54450044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
