LGTM
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js
File src/com/google/caja/ses/repair-framework.js (right):
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode302
src/com/google/caja/ses/repair-framework.js:302: var postTestKludge =
undefined;
Stale name?
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode310
src/com/google/caja/ses/repair-framework.js:310: // using direct
hasOwnProperty is safe as problem ID syntax is restricted
What does "restricted" mean here?
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode345
src/com/google/caja/ses/repair-framework.js:345: // Lock in the failure
if any since it is no longer yetToRepair
It isn't quite yet no longer yetToRepair, since you don't delete it
until the next statement below.
https://codereview.appspot.com/54450044/diff/1/src/com/google/caja/ses/repair-framework.js#newcode365
src/com/google/caja/ses/repair-framework.js:365: // TODO(kpreid): Need
to insert repair attempted statuses here
Write here clarification u just told me verbally
https://codereview.appspot.com/54450044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
