lgtm except below
https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/domado.js#newcode6760
src/com/google/caja/plugin/domado.js:6760: if (typeof console !==
'undefined') {
maybe hoist this if outside the try?
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js
File tests/com/google/caja/plugin/test-cajajs-invocation.js (right):
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js#newcode96
tests/com/google/caja/plugin/test-cajajs-invocation.js:96:
caja.load(createDiv(), uriPolicy, jsunitCallback(function(frame) {
space after function
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js#newcode115
tests/com/google/caja/plugin/test-cajajs-invocation.js:115:
.run(jsunitCallback(function(result) {
space after function
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js#newcode556
tests/com/google/caja/plugin/test-cajajs-invocation.js:556:
jsunitRun('testScriptError');
arg should be deleted, right? debugging leftover?
jsunitRun seems to me to do the wrong thing with opt_testnames anyway.
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode42
tests/com/google/caja/plugin/test-domado-events-guest.html:42:
window.onerror = (function (savedOnerror) {
this capitalization of savedOnerror feels wrong to me but all the
alternatives feel more wrong, heh
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode454
tests/com/google/caja/plugin/test-domado-events-guest.html:454: <p
class="testcontainer" id="testTimeoutError">
this is an async test, add 'waiting' to the class
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode458
tests/com/google/caja/plugin/test-domado-events-guest.html:458:
jsunitRegister('testTimeoutError', function() {
space after function for consistency, and below
https://codereview.appspot.com/153290043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
