https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/153290043/diff/1/src/com/google/caja/plugin/domado.js#newcode6760
src/com/google/caja/plugin/domado.js:6760: if (typeof console !==
'undefined') {
On 2014/10/12 20:04:50, felix8a wrote:
maybe hoist this if outside the try?
Done.
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js
File tests/com/google/caja/plugin/test-cajajs-invocation.js (right):
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js#newcode96
tests/com/google/caja/plugin/test-cajajs-invocation.js:96:
caja.load(createDiv(), uriPolicy, jsunitCallback(function(frame) {
On 2014/10/12 20:04:50, felix8a wrote:
space after function
I can't find a citation but my understanding of the style we're supposed
to be following (but historically have been mixed up about) is that
there should be no space there. I've been converting code to the
no-space style as I touch it.
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js#newcode556
tests/com/google/caja/plugin/test-cajajs-invocation.js:556:
jsunitRun('testScriptError');
On 2014/10/12 20:04:50, felix8a wrote:
arg should be deleted, right? debugging leftover?
Done.
jsunitRun seems to me to do the wrong thing with opt_testnames anyway.
Hm, yes, it's trying to do varargs but also have a second parameter, and
is a bit sloppy otherwise. Added a comment to note the problem -- not a
priority since it only affects debugging stuff.
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode42
tests/com/google/caja/plugin/test-domado-events-guest.html:42:
window.onerror = (function (savedOnerror) {
On 2014/10/12 20:04:50, felix8a wrote:
this capitalization of savedOnerror feels wrong to me but all the
alternatives
feel more wrong, heh
Exactly.
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode454
tests/com/google/caja/plugin/test-domado-events-guest.html:454: <p
class="testcontainer" id="testTimeoutError">
On 2014/10/12 20:04:50, felix8a wrote:
this is an async test, add 'waiting' to the class
My understanding was that 'waiting' was obsolete. Your TODO comment at
BrowserTestCase.java claims this. Clarify?
https://codereview.appspot.com/153290043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
