lgtm
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js
File tests/com/google/caja/plugin/test-cajajs-invocation.js (right):
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-cajajs-invocation.js#newcode96
tests/com/google/caja/plugin/test-cajajs-invocation.js:96:
caja.load(createDiv(), uriPolicy, jsunitCallback(function(frame) {
On 2014/10/13 16:58:00, kpreid_google wrote:
On 2014/10/12 20:04:50, felix8a wrote:
> space after function
I can't find a citation but my understanding of the style we're
supposed to be
following (but historically have been mixed up about) is that there
should be no
space there. I've been converting code to the no-space style as I
touch it.
personally, I prefer to remain consistent within a file, and change
style of an entire file all at once, but ok.
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html
File tests/com/google/caja/plugin/test-domado-events-guest.html (right):
https://codereview.appspot.com/153290043/diff/1/tests/com/google/caja/plugin/test-domado-events-guest.html#newcode454
tests/com/google/caja/plugin/test-domado-events-guest.html:454: <p
class="testcontainer" id="testTimeoutError">
On 2014/10/13 16:58:00, kpreid_google wrote:
On 2014/10/12 20:04:50, felix8a wrote:
> this is an async test, add 'waiting' to the class
My understanding was that 'waiting' was obsolete. Your TODO comment at
BrowserTestCase.java claims this. Clarify?
ah, right, I forgot about that. ok.
https://codereview.appspot.com/153290043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
