Comment #12 on issue 258 by limpbizkit: [Patch] custom annotation based injection points http://code.google.com/p/google-guice/issues/detail?id=258
James, your work is fantastic. Keep it up, and I'm intending on taking it all in for consideration as soon as we push v2 out the door. With respect to supporting custom annotations, my complaint is that it introduces more indirection to Guice, without adding more value. Tools like IDEs etc. can use our simple static methods on InjectionPoint.class to lookup the injection points for a given class. Should we introduce InjectionPoint Matchers, it's no longer possible to know the injection points for a class statically - you'll need a Module to figure them out. I don't think this is a net win for our users. I believe a lot of the motivation for custom annotations is people's distaste for importing 'com.google' packages into their core classes. But the same people happily import 'java.' packages everywhere. I think this is a bit irrational, because Google loves you way more than Sun or the JCP does. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
